Skip to content

added kmip server side encryption tests#2379

Merged
bert-e merged 2 commits into
development/2.14from
improvement/ZENKO-5241
Apr 29, 2026
Merged

added kmip server side encryption tests#2379
bert-e merged 2 commits into
development/2.14from
improvement/ZENKO-5241

Conversation

@SylvainSenechal
Copy link
Copy Markdown
Contributor

@SylvainSenechal SylvainSenechal commented Apr 20, 2026 •
edited
Loading

Issue: ZENKO-5241

Adding more encryption tests but with KMIP mode
A bit annoying as we need to patch the CR, and when kmip mode is enabled, the base encryption tests don't work anymore

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 20, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch 8 times, most recently from b926a78 to c30eecf Compare April 22, 2026 22:09
@scality scality deleted a comment from bert-e Apr 23, 2026
@SylvainSenechal SylvainSenechal marked this pull request as ready for review April 23, 2026 07:54
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 23, 2026

Incorrect fix version

The Fix Version/s in issue ZENKO-5241 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.14.4

Please check the Fix Version/s of ZENKO-5241, or the target
branch of this pull request.

SylvainSenechal
SylvainSenechal commented Apr 23, 2026
View reviewed changes
Comment thread solution/deps.yaml Outdated
sourceRegistry: ghcr.io/scality
image: zenko-operator
tag: v1.8.9
tag: 15b35ecc60bc8b83e855e0cb17091b10e592aa07
Copy link
Copy Markdown
Contributor Author

@SylvainSenechal SylvainSenechal Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO BE DONE
!

SylvainSenechal
SylvainSenechal commented Apr 23, 2026
View reviewed changes
Comment thread tests/ctst/common/hooks.ts
});
});

Before({ tags: '@ServerSideEncryptionKmip', timeout: 15 * 60 * 1000 },
Copy link
Copy Markdown
Contributor Author

@SylvainSenechal SylvainSenechal Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best i can come up with in CUCUMBER TESTS to have certains tests ran after others

SylvainSenechal
SylvainSenechal commented Apr 23, 2026
View reviewed changes
Comment thread tests/ctst/features/serverSideEncryption.feature
Copy link
Copy Markdown
Contributor Author

@SylvainSenechal SylvainSenechal Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, might have added too many tests that aren't super useful for FUNCTIONAL testing 🤔

@SylvainSenechal SylvainSenechal requested review from a team, delthas and maeldonn April 23, 2026 15:56
delthas
delthas approved these changes Apr 27, 2026
View reviewed changes
Comment thread tests/ctst/common/hooks.ts
});
});

Before({ tags: '@ServerSideEncryptionKmip', timeout: 15 * 60 * 1000 },
Copy link
Copy Markdown
Contributor

@delthas delthas Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an After/cleanup for this? Like I guess we make changes to the Zenko CR while the tests are running because we don't want to affect other tests; but then we should clear our changes before the next tests run, no?

Copy link
Copy Markdown
Contributor Author

@SylvainSenechal SylvainSenechal Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it without a cleanup. The cr can stay with a kmip encryption mode, anyways it won't affect the other tests as you still need to enable the encryption setting on the buckets. Changing cr again is gonna re trigger reconciliation and add some 50 lines of code function, not super useful

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch from c30eecf to 73cd374 Compare April 28, 2026 10:27
claude[bot]
claude Bot reviewed Apr 28, 2026
View reviewed changes
Comment thread .github/scripts/mocks/setup-kmip.sh
@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch from 73cd374 to 99c975b Compare April 28, 2026 14:13
maeldonn
maeldonn reviewed Apr 28, 2026
View reviewed changes
Comment thread tests/ctst/steps/serverSideEncryption.ts Outdated
Comment thread tests/ctst/steps/serverSideEncryption.ts
Comment thread tests/ctst/steps/serverSideEncryption.ts Outdated
Comment thread .github/scripts/end2end/configure-e2e-ctst.sh Outdated
@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch from 99c975b to c1b5357 Compare April 29, 2026 10:29
maeldonn
maeldonn approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@maeldonn maeldonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch from c1b5357 to 7b59d49 Compare April 29, 2026 14:33
@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5241 branch from 7b59d49 to ab42f85 Compare April 29, 2026 15:45
@scality scality deleted a comment from bert-e Apr 29, 2026
@SylvainSenechal
Copy link
Copy Markdown
Contributor Author

SylvainSenechal commented Apr 29, 2026

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

Build failed

The build for commit did not succeed in branch improvement/ZENKO-5241

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.14

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-5241.

Goodbye sylvainsenechal.

The following options are set: approve

@bert-e bert-e merged commit ab42f85 into development/2.14 Apr 29, 2026
39 of 40 checks passed
@bert-e bert-e deleted the improvement/ZENKO-5241 branch April 29, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@delthas delthas delthas approved these changes

@maeldonn maeldonn maeldonn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SylvainSenechal @bert-e @delthas @maeldonn